[ROCm] add the bias all row -inf support for jax unfused-attn#556
Open
[ROCm] add the bias all row -inf support for jax unfused-attn#556
Conversation
Micky774
reviewed
Apr 21, 2026
Contributor
|
Looks like CI is failing for incorrect broadcasting shapes |
ipanfilo
reviewed
Apr 23, 2026
| ), | ||
| ], | ||
| ) | ||
| def test_backward_bias_all_neg_inf( |
Collaborator
There was a problem hiding this comment.
I think it should be limited to CK backend then
Collaborator
Author
There was a problem hiding this comment.
Thanks. Added a ck backend guard
Micky774
reviewed
Apr 24, 2026
Contributor
|
CI failure is unrelated and we have a pass on mi35x |
Micky774
reviewed
Apr 27, 2026
Micky774
approved these changes
Apr 27, 2026
Contributor
Micky774
left a comment
Micky774
left a comment
There was a problem hiding this comment.
Left an optional suggestion, otherwise LGTM.
Co-authored-by: Meekail Zain <34613774+Micky774@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CK fixed the corner case with all row -inf in bias in ROCm/composable_kernel#3326. This also aligns with NV upstream. We added the corresponding jax pytest by modifying the jax unfused-attn.
Fixes # (issue)
Type of change
Changes
This concludes the https://github.com/ROCm/frameworks-internal/issues/14668 and https://ontrack-internal.amd.com/browse/SWDEV-561757
Checklist: