Skip to content

ci: add workflow to build and publish CI deps Docker image#555

Open
VeeraRajasekhar wants to merge 3 commits intodevfrom
veergopu/publish-docker-ci-deps-workflow
Open

ci: add workflow to build and publish CI deps Docker image#555
VeeraRajasekhar wants to merge 3 commits intodevfrom
veergopu/publish-docker-ci-deps-workflow

Conversation

@VeeraRajasekhar
Copy link
Copy Markdown
Contributor

Description

Adds a manual GitHub Actions workflow (Publish CI deps Docker image) that builds [.github/scripts/Dockerfile.ci.deps] on the linux-te-mi325-8 runner, logs into the configured container registry, and pushes the image with a caller-supplied tag. This automates publishing the TE CI dependency image to Harbor (or any Docker registry using the same login/push flow) instead of building and pushing only by hand.

Fixes # (issue)

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

Please list the changes introduced in this PR:

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes


jobs:
build-and-push:
runs-on: linux-te-mi325-8
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use te_builder for this instead?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have these runners setup?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found it in our chat, I have updated it. Thanks

ARTIFACTORY_DOCKER_PASSWORD: ${{ secrets.ARTIFACTORY_DOCKER_PASSWORD }}
run: |
set -euo pipefail
echo "${ARTIFACTORY_DOCKER_PASSWORD}" | docker login "${REGISTRY}" \
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It it fails, will password be hidden from the logs? And actually on success too: CI logs often echo commands

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to use docker login action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants