Skip to content

Update init-interfaces.sh to match case where the interface type can also be 802-3-ethernet#96

Merged
RamLavi merged 1 commit intoRHsyseng:simplify-networkingfrom
rabin-io:patch-1
May 26, 2025
Merged

Update init-interfaces.sh to match case where the interface type can also be 802-3-ethernet#96
RamLavi merged 1 commit intoRHsyseng:simplify-networkingfrom
rabin-io:patch-1

Conversation

@rabin-io
Copy link
Copy Markdown

@rabin-io rabin-io commented May 9, 2025

Match case where the interface type can also be 802-3-ethernet

@rabin-io rabin-io changed the title Update init-interfaces.sh Update init-interfaces.sh to match case where the interface type can also be 802-3-ethernet May 11, 2025
@rabin-io
Copy link
Copy Markdown
Author

/assign @RamLavi

@RamLavi
Copy link
Copy Markdown
Collaborator

RamLavi commented May 15, 2025

Hey @rabin-io can you print an example of such connections from nmcli ?

@rabin-io
Copy link
Copy Markdown
Author

$ nmcli connection show Test | grep connection.type
connection.type:                        802-3-ethernet

@RamLavi
Copy link
Copy Markdown
Collaborator

RamLavi commented May 18, 2025

CI seems to be failing due to use of a deprecated ubuntu.
Let's fix that first before merging.
I'll issue a PR

@RamLavi
Copy link
Copy Markdown
Collaborator

RamLavi commented May 26, 2025

@rabin-io please rebase

Match case where the interface type can also be `802-3-ethernet`
@rabin-io
Copy link
Copy Markdown
Author

Done

@RamLavi RamLavi merged commit 6c22f23 into RHsyseng:simplify-networking May 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants