fix: Treat LoadConstant as transparent only if Const encoded#1243
Draft
fix: Treat LoadConstant as transparent only if Const encoded#1243
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1243 +/- ##
=======================================
Coverage 79.02% 79.03%
=======================================
Files 160 160
Lines 20421 20425 +4
Branches 19489 19493 +4
=======================================
+ Hits 16138 16142 +4
Misses 3294 3294
Partials 989 989
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Alternative" to #1241 (in that the breakage had resulted from our claiming
usize_twas a supported type without having a const-encoder).This may not be right though; better might be to keep "which types are supported" in sync with "which consts can we encode", although this way does allow only some consts (of a supported type) to be encodable...
At the least, needs a test though....(somehow!)