refactor: move Rule and RuleMatcher from tket-py to core tket#1208
refactor: move Rule and RuleMatcher from tket-py to core tket#1208ankurmagdum wants to merge 1 commit intoQuantinuum:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1208 +/- ##
==========================================
+ Coverage 78.60% 78.63% +0.02%
==========================================
Files 151 153 +2
Lines 18264 18953 +689
Branches 17170 17851 +681
==========================================
+ Hits 14357 14903 +546
- Misses 3027 3108 +81
- Partials 880 942 +62
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I have discovered an incompatibility issue with guppy-based In test_rule_matcher.py, two The difference between It seems like this issue should be addressed in |
Addresses #801
I wasn't entirely sure about where exactly to include
RuleandRuleMatcherintket, so have currently placed them inportmatching::matcher. Feedback on code correctness and/or documentation would be helpful. Meanwhile, I shall continue to add tests.