feat!: do not require an Order edge for each nonlocal Ext edge; order_graph computes on demand#2951
Draft
acl-cqc wants to merge 6 commits intoacl/syn_edge_prepfrom
Draft
feat!: do not require an Order edge for each nonlocal Ext edge; order_graph computes on demand#2951acl-cqc wants to merge 6 commits intoacl/syn_edge_prepfrom
Ext edge; order_graph computes on demand#2951acl-cqc wants to merge 6 commits intoacl/syn_edge_prepfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## acl/syn_edge_prep #2951 +/- ##
=====================================================
- Coverage 81.18% 81.17% -0.01%
=====================================================
Files 240 240
Lines 44917 44891 -26
Branches 38685 38659 -26
=====================================================
- Hits 36466 36441 -25
+ Misses 6488 6487 -1
Partials 1963 1963
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6db3845 to
521319f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #3015; this just
Previous description:
Extedge - validation no longer checks this, and the builder does not add it. (Clients such as guppy will be updated separately).region_portgraphmethod currently used for (e.g.) topological sorting; this can no longer be relied upon for valid schedules, so really this is a breaking change.order_graphmethod that returns a petgraph (+node map), which includes "synthetic" edges not in the Hugr that express the ordering requirements imposed by the nonlocal edges. (That is, this method scans the relevant region of the Hugr looking for nonlocal edges.)region_portgraph, except for SiblingSubgraph, where there is some additional complexity because of traits for convexity checking.BREAKING CHANGE: Hugrs are no longer guaranteed to have an Order edge representing the ordering constraint from each nonlocal
Extedge; region_portgraph may return graphs without such edges (use order_graph) - it will return such only if they happen to be present.