Skip to content

fix: Allow check on generic functions#1666

Draft
mark-koch wants to merge 3 commits intomainfrom
fix/check-generic
Draft

fix: Allow check on generic functions#1666
mark-koch wants to merge 3 commits intomainfrom
fix/check-generic

Conversation

@mark-koch
Copy link
Copy Markdown
Collaborator

@mark-koch mark-koch commented Apr 16, 2026

Still needs tests

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 16, 2026

🐰 Bencher Report

Branchfix/check-generic
TestbedLinux

🚨 3 Alerts

BenchmarkMeasure
Units
ViewBenchmark Result
(Result Δ%)
Upper Boundary
(Limit %)
tests/benchmarks/test_big_array.py::test_big_array_compileLatency
seconds (s)
📈 plot
🚷 threshold
🚨 alert (🔔)
1.99 s
(+8.32%)Baseline: 1.84 s
1.93 s
(103.16%)

tests/benchmarks/test_ctrl_flow.py::test_many_ctrl_flow_checkLatency
milliseconds (ms)
📈 plot
🚷 threshold
🚨 alert (🔔)
106.36 ms
(+9.46%)Baseline: 97.16 ms
102.02 ms
(104.25%)

tests/benchmarks/test_ctrl_flow.py::test_many_ctrl_flow_compileLatency
milliseconds (ms)
📈 plot
🚷 threshold
🚨 alert (🔔)
238.51 ms
(+13.99%)Baseline: 209.24 ms
219.70 ms
(108.56%)

Click to view all benchmark results
BenchmarkLatencyBenchmark Result
microseconds (µs)
(Result Δ%)
Upper Boundary
microseconds (µs)
(Limit %)
tests/benchmarks/test_big_array.py::test_big_array_check📈 view plot
🚷 view threshold
745,891.77 µs
(-7.62%)Baseline: 807,447.47 µs
847,819.84 µs
(87.98%)
tests/benchmarks/test_big_array.py::test_big_array_compile📈 view plot
🚷 view threshold
🚨 view alert (🔔)
1,989,977.18 µs
(+8.32%)Baseline: 1,837,153.97 µs
1,929,011.67 µs
(103.16%)

tests/benchmarks/test_big_array.py::test_big_array_executable📈 view plot
🚷 view threshold
8,778,208.22 µs
(+3.15%)Baseline: 8,510,277.72 µs
8,935,791.61 µs
(98.24%)
tests/benchmarks/test_ctrl_flow.py::test_many_ctrl_flow_check📈 view plot
🚷 view threshold
🚨 view alert (🔔)
106,356.13 µs
(+9.46%)Baseline: 97,163.05 µs
102,021.21 µs
(104.25%)

tests/benchmarks/test_ctrl_flow.py::test_many_ctrl_flow_compile📈 view plot
🚷 view threshold
🚨 view alert (🔔)
238,512.96 µs
(+13.99%)Baseline: 209,242.49 µs
219,704.61 µs
(108.56%)

tests/benchmarks/test_ctrl_flow.py::test_many_ctrl_flow_executable📈 view plot
🚷 view threshold
990,467.18 µs
(-24.96%)Baseline: 1,319,885.76 µs
1,385,880.05 µs
(71.47%)
tests/benchmarks/test_prelude.py::test_import_guppy📈 view plot
🚷 view threshold
49.34 µs
(+4.31%)Baseline: 47.31 µs
49.67 µs
(99.34%)
tests/benchmarks/test_queue_push_pop.py::test_queue_push_benchmark📈 view plot
🚷 view threshold
474,942.99 µs
(-2.74%)Baseline: 488,312.63 µs
512,728.26 µs
(92.63%)
tests/benchmarks/test_queue_push_pop.py::test_queue_push_pop_benchmark📈 view plot
🚷 view threshold
625,109.70 µs
(-3.40%)Baseline: 647,095.18 µs
679,449.94 µs
(92.00%)
🐰 View full continuous benchmarking report in Bencher

@github-actions
Copy link
Copy Markdown
Contributor

🐰 Bencher Report

Branchfix/check-generic
TestbedLinux
Click to view all benchmark results
Benchmarkhugr_bytesBenchmark Result
bytes x 1e3
(Result Δ%)
Upper Boundary
bytes x 1e3
(Limit %)
hugr_nodesBenchmark Result
nodes x 1e3
(Result Δ%)
Upper Boundary
nodes x 1e3
(Limit %)
tests/benchmarks/test_big_array.py::test_big_array_compile📈 view plot
🚷 view threshold
158.77 x 1e3
(0.00%)Baseline: 158.77 x 1e3
160.36 x 1e3
(99.01%)
📈 view plot
🚷 view threshold
6.64 x 1e3
(0.00%)Baseline: 6.64 x 1e3
6.71 x 1e3
(99.01%)
tests/benchmarks/test_ctrl_flow.py::test_many_ctrl_flow_compile📈 view plot
🚷 view threshold
27.53 x 1e3
(0.00%)Baseline: 27.53 x 1e3
27.81 x 1e3
(99.01%)
📈 view plot
🚷 view threshold
1.07 x 1e3
(0.00%)Baseline: 1.07 x 1e3
1.08 x 1e3
(99.01%)
🐰 View full continuous benchmarking report in Bencher

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 16, 2026

Codecov Report

❌ Patch coverage is 68.18182% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.50%. Comparing base (f8cf7bb) to head (95c91de).

Files with missing lines Patch % Lines
...pylang-internals/src/guppylang_internals/engine.py 68.18% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1666      +/-   ##
==========================================
- Coverage   93.55%   93.50%   -0.05%     
==========================================
  Files         133      133              
  Lines       12641    12660      +19     
==========================================
+ Hits        11826    11838      +12     
- Misses        815      822       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants