feat(diagnostics)!: Emit warning for unreachable code#1660
Draft
ss2165 wants to merge 2 commits intoss/push-kvqpqswszwxofrom
Draft
feat(diagnostics)!: Emit warning for unreachable code#1660ss2165 wants to merge 2 commits intoss/push-kvqpqswszwxofrom
ss2165 wants to merge 2 commits intoss/push-kvqpqswszwxofrom
Conversation
Contributor
Contributor
|
| Branch | ss/push-okqyxvllnpnk |
| Testbed | Linux |
Click to view all benchmark results
| Benchmark | hugr_bytes | Benchmark Result bytes x 1e3 (Result Δ%) | Upper Boundary bytes x 1e3 (Limit %) | hugr_nodes | Benchmark Result nodes x 1e3 (Result Δ%) | Upper Boundary nodes x 1e3 (Limit %) |
|---|---|---|---|---|---|---|
| tests/benchmarks/test_big_array.py::test_big_array_compile | 📈 view plot 🚷 view threshold | 158.77 x 1e3(0.00%)Baseline: 158.77 x 1e3 | 160.36 x 1e3 (99.01%) | 📈 view plot 🚷 view threshold | 6.64 x 1e3(0.00%)Baseline: 6.64 x 1e3 | 6.71 x 1e3 (99.01%) |
| tests/benchmarks/test_ctrl_flow.py::test_many_ctrl_flow_compile | 📈 view plot 🚷 view threshold | 27.53 x 1e3(0.00%)Baseline: 27.53 x 1e3 | 27.81 x 1e3 (99.01%) | 📈 view plot 🚷 view threshold | 1.07 x 1e3(0.00%)Baseline: 1.07 x 1e3 | 1.08 x 1e3 (99.01%) |
b0ef8a3 to
069945a
Compare
a9570d0 to
a4a1b20
Compare
069945a to
8a59cd4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## ss/push-kvqpqswszwxo #1660 +/- ##
========================================================
+ Coverage 93.54% 93.56% +0.01%
========================================================
Files 134 134
Lines 12744 12749 +5
========================================================
+ Hits 11922 11929 +7
+ Misses 822 820 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8a59cd4 to
d4e25bc
Compare
a4a1b20 to
74aefe0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #739
Based on warning framework in #1659
Add
run_warning_testfor rendered warning testsAssert warning is appropriately raised in existing unreachable tests
Developed in iteration with Codex.
BREAKING CHANGE: internals: UnreachableError (unused) renamed to UnreachableWarning