Open
Conversation
Contributor
OneReality
commented
Apr 25, 2020
- added new vimeo event example.
- demonstrates how a vimeo event or media URL can be used instead of media ID.
- uses Fullscreen example as base
…a URL can be used instead of media ID. uses Fullscreen example as base
ptvandi
suggested changes
Apr 27, 2020
Contributor
ptvandi
left a comment
There was a problem hiding this comment.
Hey @OneReality, looks good. Just a few superficial changes. Do we want to create a fiddle for this and list it in the Vimeo README?
| const button = document.querySelector('#fullscreen-button'); | ||
|
|
||
| // Initialize the Vimeo Player. Use the Vimeo URL (Media or Event URL) | ||
| // NOTE - It is recommended you turn off the "Fullscreen" option for this video's embed on your Vimeo Dashboard under Video - Embed - Controls |
Contributor
There was a problem hiding this comment.
Suggested change
| // NOTE - It is recommended you turn off the "Fullscreen" option for this video's embed on your Vimeo Dashboard under Video - Embed - Controls | |
| // Note: It is recommended you turn off the "Fullscreen" option for this video's | |
| // embed in your Vimeo Dashboard (under Video > Embed > Controls). |
|
|
||
| // Initialize the Vimeo Player. Use the Vimeo URL (Media or Event URL) | ||
| // NOTE - It is recommended you turn off the "Fullscreen" option for this video's embed on your Vimeo Dashboard under Video - Embed - Controls | ||
| var options = { |
Contributor
There was a problem hiding this comment.
Suggested change
| var options = { | |
| const options = { |
| width:'100%' | ||
| }; | ||
|
|
||
| var player = new Vimeo.Player('vimeo-container', options); |
Contributor
There was a problem hiding this comment.
Suggested change
| var player = new Vimeo.Player('vimeo-container', options); | |
| const player = new Vimeo.Player('vimeo-container', options); |
Comment on lines
+93
to
+95
| player.ready().then(function() { | ||
| ptvsdk.start() | ||
| }); |
Contributor
There was a problem hiding this comment.
Suggested change
| player.ready().then(function() { | |
| ptvsdk.start() | |
| }); | |
| player.ready().then(() => ptvsdk.start()); |
| // Find the Full Screen Button | ||
| const button = document.querySelector('#fullscreen-button'); | ||
|
|
||
| // Initialize the Vimeo Player. Use the Vimeo URL (Media or Event URL) |
Contributor
There was a problem hiding this comment.
Suggested change
| // Initialize the Vimeo Player. Use the Vimeo URL (Media or Event URL) | |
| // Initialize the Vimeo Player. Use the Vimeo URL (Media or Event URL). |
| </div> | ||
|
|
||
| <script> | ||
| // Find the Full Screen Button |
Contributor
There was a problem hiding this comment.
Suggested change
| // Find the Full Screen Button | |
| // Find fullscreen button |
| <head> | ||
| <meta charset="utf-8"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1"> | ||
| <title>Vimeo Event FullScreen</title> |
Contributor
There was a problem hiding this comment.
Suggested change
| <title>Vimeo Event FullScreen</title> | |
| <title>Vimeo Event Fullscreen</title> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.