Skip to content

Vimeo Event Example#10

Open
OneReality wants to merge 1 commit intomasterfrom
feature/vimeo-event-url-support
Open

Vimeo Event Example#10
OneReality wants to merge 1 commit intomasterfrom
feature/vimeo-event-url-support

Conversation

@OneReality
Copy link
Copy Markdown
Contributor

  • added new vimeo event example.
  • demonstrates how a vimeo event or media URL can be used instead of media ID.
  • uses Fullscreen example as base

…a URL can be used instead of media ID. uses Fullscreen example as base
@OneReality OneReality requested a review from ptvandi April 25, 2020 00:53
Copy link
Copy Markdown
Contributor

@ptvandi ptvandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @OneReality, looks good. Just a few superficial changes. Do we want to create a fiddle for this and list it in the Vimeo README?

Comment thread vimeo/event.html
const button = document.querySelector('#fullscreen-button');

// Initialize the Vimeo Player. Use the Vimeo URL (Media or Event URL)
// NOTE - It is recommended you turn off the "Fullscreen" option for this video's embed on your Vimeo Dashboard under Video - Embed - Controls
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// NOTE - It is recommended you turn off the "Fullscreen" option for this video's embed on your Vimeo Dashboard under Video - Embed - Controls
// Note: It is recommended you turn off the "Fullscreen" option for this video's
// embed in your Vimeo Dashboard (under Video > Embed > Controls).

Comment thread vimeo/event.html

// Initialize the Vimeo Player. Use the Vimeo URL (Media or Event URL)
// NOTE - It is recommended you turn off the "Fullscreen" option for this video's embed on your Vimeo Dashboard under Video - Embed - Controls
var options = {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var options = {
const options = {

Comment thread vimeo/event.html
width:'100%'
};

var player = new Vimeo.Player('vimeo-container', options);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var player = new Vimeo.Player('vimeo-container', options);
const player = new Vimeo.Player('vimeo-container', options);

Comment thread vimeo/event.html
Comment on lines +93 to +95
player.ready().then(function() {
ptvsdk.start()
});
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
player.ready().then(function() {
ptvsdk.start()
});
player.ready().then(() => ptvsdk.start());

Comment thread vimeo/event.html
// Find the Full Screen Button
const button = document.querySelector('#fullscreen-button');

// Initialize the Vimeo Player. Use the Vimeo URL (Media or Event URL)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Initialize the Vimeo Player. Use the Vimeo URL (Media or Event URL)
// Initialize the Vimeo Player. Use the Vimeo URL (Media or Event URL).

Comment thread vimeo/event.html
</div>

<script>
// Find the Full Screen Button
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Find the Full Screen Button
// Find fullscreen button

Comment thread vimeo/event.html
<head>
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1">
<title>Vimeo Event FullScreen</title>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<title>Vimeo Event FullScreen</title>
<title>Vimeo Event Fullscreen</title>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants