refactor: smol moving around db/network calls

[Prajna1999]

Summary

Target issue is #PLEASE_TYPE_ISSUE_NUMBER
Explain the motivation for making this change. What existing problem does the pull request solve?

Checklist

Before submitting a pull request, please ensure that you mark these task.

• Ran fastapi run --reload app/main.py or docker compose up in the repository root and test.
• If you've fixed a bug or added code that is tested and has test cases.

Notes

Please add here if any other information is required for the reviewer.

Summary by CodeRabbit

• Refactor
  • Improved collection creation performance by restructuring document batching workflow and reducing the number of database queries required during processing.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 903e0330-c9e8-4016-a372-765acaae98de

📥 Commits

Reviewing files that changed from the base of the PR and between 0ca58bd and a0732ee.

📒 Files selected for processing (2)

• backend/app/services/collections/create_collection.py
• backend/app/services/collections/providers/openai.py

---

📝 Walkthrough

Walkthrough

Document batching logic is relocated from OpenAIProvider.create to the caller (execute_job in create_collection.py). The provider now receives pre-batched documents (list[list[Document]]) instead of a DocumentCrud instance, eliminating secondary database reads.

Changes

Cohort / File(s)	Summary
Collection Creation Service backend/app/services/collections/create_collection.py	Moves document batching responsibility to execute_job; batches documents by batch_size before provider invocation, removing the secondary DocumentCrud.read_each database query.
OpenAI Provider backend/app/services/collections/providers/openai.py	Updates create method signature to accept pre-batched documents (docs_batches: list[list[Document]]) instead of DocumentCrud instance; removes internal batching logic and related imports.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• Fix/db connection pool limit #744: Implements the same provider signature refactoring pattern, replacing DocumentCrud parameter with pre-batched documents and shifting batching responsibility to the caller.

Suggested reviewers

• vprashrex

Poem

🐰 Batching hops from here to there,
Pre-grouped docs float through the air!
One less query, cleaner call,
The provider's load grows small. ✨

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/collection-session-leaks

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}