Fix StartGameCommand getting "cmd /c" prefix on Linux containers when host is Windows#207
Merged
dgkanatsios merged 3 commits intomainfrom Mar 30, 2026
Merged
Conversation
…ers on Windows When running Linux containers on Windows (with -lcow flag), GetStartGameCmd and GetGameWorkingDir in DockerContainerEngine incorrectly checked the host OS instead of the container OS. This caused "cmd /c" to be prepended to Linux commands and Windows-specific working directory logic to be applied to Linux containers. The fix passes the isLinuxContainersOnWindows flag (already available via sessionHostManager.LinuxContainersOnWindows) to both methods, and gates the Windows-specific logic on the container not being a Linux container on Windows. Agent-Logs-Url: https://github.com/PlayFab/MpsAgent/sessions/12c2a2a6-39e7-488c-bc18-99f522c21860 Co-authored-by: dgkanatsios <8256138+dgkanatsios@users.noreply.github.com>
Agent-Logs-Url: https://github.com/PlayFab/MpsAgent/sessions/12c2a2a6-39e7-488c-bc18-99f522c21860 Co-authored-by: dgkanatsios <8256138+dgkanatsios@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix MpsAgent prefix issue with StartGameCommand on Linux
Fix StartGameCommand getting "cmd /c" prefix on Linux containers when host is Windows
Mar 30, 2026
dgkanatsios
approved these changes
Mar 30, 2026
jotavalenciano
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetStartGameCmdandGetGameWorkingDirinDockerContainerEnginecheck_systemOperations.IsOSPlatform(OSPlatform.Windows)to decide whether to prependcmd /cand derive a Windows working directory. This checks the host OS, not the container OS—so Linux containers on Windows (via-lcow) getcmd /c sleep 100which fails immediately.Changes
DockerContainerEngine.cs: PassisLinuxContainersOnWindows(already available fromsessionHostManager.LinuxContainersOnWindows) intoGetStartGameCmdandGetGameWorkingDir. Gate Windows-specific logic onIsOSPlatform(Windows) && !isLinuxContainersOnWindows.VmAgent.Core.csproj: AddInternalsVisibleTofor test project.DockerContainerEngineTests.cs: 8 new tests covering lcow, native Windows, native Linux, and null/empty command cases.