Add build comparison tab#9543
Open
oboking wants to merge 2 commits intoPathOfBuildingCommunity:devfrom
Open
Conversation
Member
|
I'll have to play with it once the league start work calms down. Just from the gif you need a ConfigSet dropdown too. You could use the Tree comparison feature in that tab to make direct comparison easier. Not sure how that ends up looking with different jewels and such, though. We've previously been hesitant to add something like this because of performance concerns, but if this just compares the XML it might be okay. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An initial way to address:
#8817
#7816
#4402
Description of the problem being solved:
I myself always end up with one PoB application for my actual imported character from the game, and one window for the goal PoB I'm going for, and its quite annoying to juggle both applications and spot the differences between the PoB's if you don't know what you are missing.
There are many ways the feature could be improved (for example overlaying trees, better explanations for the sources of the stats in the calcs tab, key differences across tabs in the summary tab, colored gems in the skills tab etc) but I think it serves most of my needs pretty good.
Video of feature:
showcase.mp4
I would love to hear your guys input on it 😄