Fallback to application/octet-stream content type when for invalid UTF-8 message bodies so ServicePulse will not fail loading the BLOB#5394
Open
ramonsmits wants to merge 2 commits intomasterfrom
Conversation
…data When a message body fails UTF-8 decoding despite the content type header claiming text, update the metadata content type to application/octet-stream and fall back to body storage instead of silently dropping the body.
ramonsmits
changed the title
application/octet-stream content type when for invalid UTF-8 message bodies so ServicePulse will not fail loading the BLOB
danielmarbach
approved these changes
Mar 20, 2026
When a failed message body is not valid UTF-8 despite the content type header, update metadata and attachment content type to application/octet-stream. Replay is unaffected as it uses the original message headers, not metadata.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DecoderFallbackExceptionhandler now updatesMessageMetadata["ContentType"]toapplication/octet-streamand falls back to body storageImpact on ServicePulse
contentTypeParser.ts: application/octet-stream falls into the application/ branch but doesn't match +json or +xml, so it returns { isSupported: false }.BodyView.vuewill show : "Message body cannot be displayed because content type application/octet-stream is not supported." This is an improvement over the current behavior where ServicePulse tries to parse binary data as JSON/XML and crashes.MessageStore.ts: the JSON/XML formatting try block won't trigger for application/octet-stream, so no parse errors.EditRetryDialog.vue: edit & retry will be disabled with a warning that the content type is not supported. Correct behavior for binary data.