NMS-19535: Don't disable rpm's internal dependency generator#8306
Open
NMS-19535: Don't disable rpm's internal dependency generator#8306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting
%define _use_internal_dependency_generator 0is broken as of rpm v6, and will result in failure:External dependency generation has been removed in rpm format v6, hence internal dependency generation must be allowed.
I frequently build in an environment that packages using a much newer
rpmand setting this to0broke those builds. Removing_use_internal_dependency_generator 0allows the rpm build to complete and doesn't appear to have any deleterious effects aside from the two fixes noted below.This adds a specific exclude for an ancient libstdc++-libc6.2 that "something" we're packing depends on that I assume the internal dependency generator discovered, and in addition adds an explicit
Provides:for the user and group for core, minion, and sentinel, the lack of which appeared to cause an issue where we somehowRequires: user(opennms)that couldn't resolve because none of the packagesProvides:it.External References