Handle Intel's emerald rapids and do some formatting in the cpuid_x86 file#5659
Open
lindsayad wants to merge 3 commits intoOpenMathLib:developfrom
Open
Handle Intel's emerald rapids and do some formatting in the cpuid_x86 file#5659lindsayad wants to merge 3 commits intoOpenMathLib:developfrom
lindsayad wants to merge 3 commits intoOpenMathLib:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The instruction set for emerald rapids is the same as sapphire rapids so I select the same arch's for the emerald rapids branches as for the sapphire rapids branches, e.g.
I was also having a very hard time following the code with the different indentation levels so I've clang-formatted the file. I can understand if this is undesirable so I will revert if asked, but in my opinion it significantly improves the file's readability.