[PATCH v5] api: timer: add flow control parameter for periodic timer timeout events#2311
Open
MatiasElo wants to merge 2 commits intoOpenDataPlane:masterfrom
Open
[PATCH v5] api: timer: add flow control parameter for periodic timer timeout events#2311MatiasElo wants to merge 2 commits intoOpenDataPlane:masterfrom
MatiasElo wants to merge 2 commits intoOpenDataPlane:masterfrom
Conversation
odpbuild
changed the title
MatiasElo
force-pushed
the
dev/timer-flow-control
branch
from
efa4667 to
74ffc46
Compare
odpbuild
changed the title
psavol
approved these changes
Mar 17, 2026
MatiasElo
force-pushed
the
dev/timer-flow-control
branch
from
74ffc46 to
c0f4f85
Compare
odpbuild
changed the title
|
|
||
| static int check_periodic_sched_flow_control_support(void) | ||
| { | ||
| if (global_mem->timer_capa.periodic.max_pools && global_mem->timer_capa.queue_type_sched && |
Collaborator
There was a problem hiding this comment.
When merging, need to remember to use the new support bits introduced in #2323 (instead of max_pools).
Collaborator
Author
There was a problem hiding this comment.
Yep, it's better to merge the more complex changes first and then rebase this one.
|
|
||
| static int check_periodic_plain_flow_control_support(void) | ||
| { | ||
| if (global_mem->timer_capa.periodic.max_pools && global_mem->timer_capa.queue_type_plain && |
Collaborator
There was a problem hiding this comment.
When merging, need to remember to use the new support bits introduced in #2323 (instead of max_pools).
Add new odp_timer_pool_param_t.periodic.max_pending_tmo parameter and matching capabilities odp_timer_capability_t.periodic.min/max_pending_tmo for configuring flow control for periodic timer pools. Signed-off-by: Matias Elo <matias.elo@nokia.com> Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com> Reviewed-by: Tuomas Taipale <tuomas.taipale@nokia.com>
MatiasElo
force-pushed
the
dev/timer-flow-control
branch
from
c0f4f85 to
93d864f
Compare
odpbuild
changed the title
Add validation tests for periodic timer pool flow control. Signed-off-by: Matias Elo <matias.elo@nokia.com> Reviewed-by: Tuomas Taipale <tuomas.taipale@nokia.com>
MatiasElo
force-pushed
the
dev/timer-flow-control
branch
from
93d864f to
68d3684
Compare
odpbuild
changed the title
TuomasTaipale
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V3: