[PATCH v7] api: timer: timer busy#2310
Merged
MatiasElo merged 5 commits intoOpenDataPlane:masterfrom Mar 27, 2026
Merged
Conversation
ba1fe46 to
3d6e70e
Compare
3d6e70e to
f2825e0
Compare
f2825e0 to
30d38d2
Compare
Contributor
PavanNikhilesh
left a comment
There was a problem hiding this comment.
Acked-by: Pavan Nikhilesh pbhagavatula@marvell.com
MatiasElo
reviewed
Feb 19, 2026
30d38d2 to
23db554
Compare
MatiasElo
reviewed
Mar 23, 2026
MatiasElo
approved these changes
Mar 27, 2026
23db554 to
4c78fde
Compare
Occasionally with certain timer implementations, start and restart operations may fail due to some resources being temporarily exhausted or busy leading to transient errors. Add new `odp_timer_retval_t::ODP_TIMER_BUSY` error code for start (oneshot and periodic) and restart operations to represent this busy condition. The operations are likely to succeed once enough resources are again available. Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com> Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com> Reviewed-by: Matias Elo <matias.elo@nokia.com> Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Add tests for the new `odp_timer_retval_t::ODP_TIMER_BUSY` error code. Actual busy condition is difficult to setup at validation test level so simply check the condition in start and restart cases. Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com> Reviewed-by: Matias Elo <matias.elo@nokia.com>
Handle new `odp_timer_retval_t::ODP_TIMER_BUSY` error code. Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com> Reviewed-by: Matias Elo <matias.elo@nokia.com>
Handle new `odp_timer_retval_t::ODP_TIMER_BUSY` error code. Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com> Reviewed-by: Matias Elo <matias.elo@nokia.com>
Handle new `odp_timer_retval_t::ODP_TIMER_BUSY` error code. Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com> Reviewed-by: Matias Elo <matias.elo@nokia.com>
4c78fde to
f969b9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft for new "resources busy" error code for oneshot timer start/restart. Still open if periodic start should also have the new error code.
v2:
v4:
v5:
v6: