Skip to content

[PATCH v7] api: timer: timer busy#2310

Merged
MatiasElo merged 5 commits intoOpenDataPlane:masterfrom
TuomasTaipale:dev/add_tmr_busy
Mar 27, 2026
Merged

[PATCH v7] api: timer: timer busy#2310
MatiasElo merged 5 commits intoOpenDataPlane:masterfrom
TuomasTaipale:dev/add_tmr_busy

Conversation

@TuomasTaipale
Copy link
Copy Markdown
Collaborator

@TuomasTaipale TuomasTaipale commented Feb 4, 2026

Draft for new "resources busy" error code for oneshot timer start/restart. Still open if periodic start should also have the new error code.

v2:

  • Added timer busy also to periodic timer start

v4:

  • Rebased
  • Added validation tests and modified relevant performance tests accordingly
  • Ready for review

v5:

  • Rebased
  • Matias' comment

v6:

  • Rebased
  • Added review tags

@odpbuild odpbuild changed the title api: timer: timer busy [PATCH v1] api: timer: timer busy Feb 4, 2026
@odpbuild odpbuild changed the title [PATCH v1] api: timer: timer busy [PATCH v2] api: timer: timer busy Feb 5, 2026
@odpbuild odpbuild changed the title [PATCH v2] api: timer: timer busy [PATCH v3] api: timer: timer busy Feb 13, 2026
@odpbuild odpbuild changed the title [PATCH v3] api: timer: timer busy [PATCH v4] api: timer: timer busy Feb 13, 2026
@TuomasTaipale TuomasTaipale marked this pull request as ready for review February 13, 2026 10:23
Copy link
Copy Markdown
Contributor

@PavanNikhilesh PavanNikhilesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acked-by: Pavan Nikhilesh pbhagavatula@marvell.com

@odpbuild odpbuild changed the title [PATCH v4] api: timer: timer busy [PATCH v5] api: timer: timer busy Feb 23, 2026
@MatiasElo MatiasElo added this to the v1.50.0 milestone Mar 12, 2026
Copy link
Copy Markdown
Collaborator

@psavol psavol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the API commit

@MatiasElo MatiasElo added the API spec OK API specification is ready. Needs implementation and test updates. label Mar 23, 2026
@odpbuild odpbuild changed the title [PATCH v5] api: timer: timer busy [PATCH v6] api: timer: timer busy Mar 27, 2026
@MatiasElo MatiasElo added API Ready API change ready to be merged (with the next API version increment) and removed API spec OK API specification is ready. Needs implementation and test updates. labels Mar 27, 2026
Occasionally with certain timer implementations, start and restart
operations may fail due to some resources being temporarily exhausted
or busy leading to transient errors.

Add new `odp_timer_retval_t::ODP_TIMER_BUSY` error code for start
(oneshot and periodic) and restart operations to represent this
busy condition. The operations are likely to succeed once enough
resources are again available.

Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com>
Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com>
Reviewed-by: Matias Elo <matias.elo@nokia.com>
Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Add tests for the new `odp_timer_retval_t::ODP_TIMER_BUSY` error
code. Actual busy condition is difficult to setup at validation
test level so simply check the condition in start and restart cases.

Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com>
Reviewed-by: Matias Elo <matias.elo@nokia.com>
Handle new `odp_timer_retval_t::ODP_TIMER_BUSY` error code.

Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com>
Reviewed-by: Matias Elo <matias.elo@nokia.com>
Handle new `odp_timer_retval_t::ODP_TIMER_BUSY` error code.

Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com>
Reviewed-by: Matias Elo <matias.elo@nokia.com>
Handle new `odp_timer_retval_t::ODP_TIMER_BUSY` error code.

Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com>
Reviewed-by: Matias Elo <matias.elo@nokia.com>
@odpbuild odpbuild changed the title [PATCH v6] api: timer: timer busy [PATCH v7] api: timer: timer busy Mar 27, 2026
@MatiasElo MatiasElo enabled auto-merge (rebase) March 27, 2026 11:35
@MatiasElo MatiasElo merged commit 272374b into OpenDataPlane:master Mar 27, 2026
255 of 256 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API Ready API change ready to be merged (with the next API version increment)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants