chore(deps): upgrade eslint to v10, drop unmaintained eslint-plugin-solid

[fank]

Summary

• Upgrades ESLint from 9.39.3 to 10.1.0 (supersedes chore(deps-dev): bump eslint from 9.39.3 to 10.1.0 in /ui #352)
• Removes eslint-plugin-solid — unmaintained since Dec 2024 with no ESLint v10 support (#200, #203)
• Disables no-unassigned-vars (new v10 rule incompatible with SolidJS's ref pattern)
• Removes stale solid/reactivity eslint-disable comments
• Fixes no-useless-assignment in RecordingSelector sort logic

The most valuable rules lost are solid/reactivity and solid/no-destructure, but there is no maintained alternative. TypeScript covers most of the other checks.

Test plan

• npx eslint . — 0 errors, 4 pre-existing warnings
• npx vite build — passes
• npx vitest run — 1494 tests pass

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a significant maintenance update by upgrading the project's ESLint dependency to its major version 10. This upgrade was accompanied by the removal of the eslint-plugin-solid due to its lack of maintenance and incompatibility with the new ESLint version. Consequently, specific ESLint rules were adjusted to accommodate SolidJS patterns and remove obsolete configurations, ensuring the linting process remains effective and compatible with the updated tooling. The changes aim to modernize the development environment and streamline the linting setup.

Highlights

• ESLint Upgrade: Upgraded ESLint from version 9.39.3 to 10.1.0, bringing the project up to date with the latest linter features and improvements.
• Removal of eslint-plugin-solid: Removed the eslint-plugin-solid due to it being unmaintained and lacking support for ESLint v10, necessitating adjustments to SolidJS-specific linting.
• ESLint Rule Adjustments: Disabled the new no-unassigned-vars rule in ESLint v10, as it conflicts with SolidJS's ref pattern, and removed stale solid/reactivity disable comments.
• Codebase Fix: Fixed a no-useless-assignment ESLint rule violation in the RecordingSelector sort logic by explicitly typing a variable.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request performs a major upgrade of ESLint from version 9 to 10, which involved significant changes to the ESLint configuration in ui/eslint.config.js. This included removing the eslint-plugin-solid package and its associated rules, adding an ignores array for specific files, and explicitly disabling the no-unassigned-vars rule to accommodate SolidJS ref patterns. Corresponding dependency updates were made in ui/package.json and ui/package-lock.json. Minor TypeScript type annotations were also adjusted, and eslint-disable-next-line comments related to solid/reactivity were removed, as they are no longer necessary with the updated linting setup.

[github-actions]

Coverage Report for ui

Status	Category	Percentage	Covered / Total
🔵	Lines	99.03% 🟰 ±0%	4838 / 4885
🔵	Statements	98.44% 🟰 ±0%	6729 / 6835
🔵	Functions	97.83% 🟰 ±0%	1899 / 1941
🔵	Branches	89.16% 🟰 ±0%	2223 / 2493

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
ui/src/pages/recording-selector/RecordingSelector.tsx	97.13% ⬇️ -0.01%	90.97% 🟰 ±0%	95.69% 🟰 ±0%	97.97% ⬇️ -0.01%	98, 169, 271-273, 314, 345, 494, 585, 596
ui/src/pages/recording-selector/dialogs.tsx	96.24% 🟰 ±0%	69.09% 🟰 ±0%	94.44% 🟰 ±0%	98.24% 🟰 ±0%	34, 42, 106, 144, 152-154, 159, 166, 185, 280, 320

Generated in workflow #461 for commit 16129f3 by the Vitest Coverage Report Action