Fix nightly CI failures from unused ARM feature gates#66
Merged
Conversation
Agent-Logs-Url: https://github.com/Nugine/simd/sessions/ecefbee2-a139-434b-9860-c712650fec53 Co-authored-by: Nugine <30099658+Nugine@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Nugine
March 26, 2026 15:21
View session
There was a problem hiding this comment.
Pull request overview
Fixes nightly CI failures triggered by enabling the arm_target_feature nightly feature gate on non-ARM targets when building the SIMD crates with --features unstable.
Changes:
- Gate
feature(arm_target_feature)behindall(feature = "unstable", target_arch = "arm")to avoidunused_featureswarnings on non-ARM targets. - Apply the same gating consistently across
hex-simd,base64-simd,base32-simd, andunicode-simd.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/unicode-simd/src/lib.rs | Restricts arm_target_feature to unstable ARM builds only. |
| crates/hex-simd/src/lib.rs | Restricts arm_target_feature to unstable ARM builds only. |
| crates/base64-simd/src/lib.rs | Restricts arm_target_feature to unstable ARM builds only. |
| crates/base32-simd/src/lib.rs | Restricts arm_target_feature to unstable ARM builds only. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix nightly CI failures caused by unconditional
arm_target_featurecrate feature gates being enabled for non-ARM unstable test builds.Changes
arm_target_featuretoall(feature = "unstable", target_arch = "arm")inhex-simd,base64-simd,base32-simd, andunicode-simdunused_featureswarnings on x86, wasm, and other CI targetsValidation
cargo testcargo check --all-targetscargo +nightly fmt --all -- --checkcargo +nightly clippy -- -D warningscargo +nightly build --release --workspace --testscargo test --release --workspace --exclude simd-benchescargo +nightly test --target x86_64-unknown-linux-gnu -p hex-simd --lib --tests --no-default-features --features unstablecargo +nightly test --target x86_64-unknown-linux-gnu -p base64-simd --lib --tests --no-default-features --features unstablecargo +nightly test --target x86_64-unknown-linux-gnu -p base32-simd --lib --tests --no-default-features --features unstablecargo +nightly test --target x86_64-unknown-linux-gnu -p unicode-simd --lib --tests --no-default-features --features unstableSecurity Summary