Skip to content

Fix CI MSRV failure: bump MSRV to 1.85.0 and commit Cargo.lock#62

Merged
Nugine merged 4 commits intomainfrom
copilot/fix-ci-failure
Feb 26, 2026
Merged

Fix CI MSRV failure: bump MSRV to 1.85.0 and commit Cargo.lock#62
Nugine merged 4 commits intomainfrom
copilot/fix-ci-failure

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 25, 2026

  • Bump MSRV to 1.85.0 in ci.yml (1.70.01.85.0)
  • Bump rust-version in all crates' Cargo.toml (1.631.85.0)
  • Revert uuid version cap in uuid-simd/Cargo.toml (back to "1.3.0", resolves to uuid v1.21.0)
  • Remove Cargo.lock from .gitignore and commit the latest lock file
  • Fix clippy::ref_as_ptr lint in crates/vsimd/src/tools.rs — use core::ptr::from_ref::<A>(a) instead of a as *const A

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: Nugine <30099658+Nugine@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix continuous integration failure Fix CI MSRV failure: cap uuid dependency below 1.21.0 Feb 25, 2026
Copilot AI requested a review from Nugine February 25, 2026 17:09
@Nugine
Copy link
Copy Markdown
Owner

Nugine commented Feb 25, 2026

@copilot

  1. Bump our MSRV to 1.85.0. Hint: search all 1.70.0 occurrences.
  2. Commit latest Cargo.lock
  3. Do not cap uuid version

Co-authored-by: Nugine <30099658+Nugine@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Feb 25, 2026

@copilot

  1. Bump our MSRV to 1.85.0. Hint: search all 1.70.0 occurrences.
  2. Commit latest Cargo.lock
    ...

Done in commit 3c02795:

  1. Bumped MSRV to 1.85.0 — updated 1.70.0 in ci.yml and rust-version = "1.63""1.85.0" in all crates' Cargo.toml.
  2. Committed latest Cargo.lock (removed from .gitignore; resolves to uuid v1.21.0).
  3. Reverted the uuid version cap back to "1.3.0".

Copilot AI changed the title Fix CI MSRV failure: cap uuid dependency below 1.21.0 Fix CI MSRV failure: bump MSRV to 1.85.0 and commit Cargo.lock Feb 25, 2026
@Nugine
Copy link
Copy Markdown
Owner

Nugine commented Feb 26, 2026

Co-authored-by: Nugine <30099658+Nugine@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Feb 26, 2026

@copilot fix CI failure https://github.com/Nugine/simd/actions/runs/22414140902/job/64937319833?pr=62

Fixed in commit f7c7f82. The develop job was failing due to a clippy::ref_as_ptr lint (part of clippy::pedantic) in crates/vsimd/src/tools.rs:103. Changed a as *const A to core::ptr::from_ref::<A>(a) as clippy suggested.

@Nugine Nugine marked this pull request as ready for review February 26, 2026 15:16
Copilot AI review requested due to automatic review settings February 26, 2026 15:16
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s Rust minimum supported version (MSRV) and dependency lock state to resolve CI failures on the MSRV job.

Changes:

  • Bump CI MSRV toolchain to Rust 1.85.0.
  • Bump rust-version to 1.85.0 across all workspace crates.
  • Commit a workspace Cargo.lock and stop ignoring it; adjust a clippy lint in vsimd utilities.

Reviewed changes

Copilot reviewed 8 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.github/workflows/ci.yml Updates the MSRV toolchain used in the CI matrix.
crates/vsimd/src/tools.rs Adjusts pointer conversion to satisfy clippy::ref_as_ptr.
crates/vsimd/Cargo.toml Bumps crate MSRV (rust-version).
crates/uuid-simd/Cargo.toml Bumps crate MSRV (rust-version).
crates/unicode-simd/Cargo.toml Bumps crate MSRV (rust-version).
crates/hex-simd/Cargo.toml Bumps crate MSRV (rust-version).
crates/base64-simd/Cargo.toml Bumps crate MSRV (rust-version).
crates/base32-simd/Cargo.toml Bumps crate MSRV (rust-version).
.gitignore Stops ignoring Cargo.lock so it can be committed.
Cargo.lock Adds the generated lockfile to pin CI/dev dependency resolution.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Nugine Nugine merged commit 34de3d2 into main Feb 26, 2026
13 checks passed
@Nugine Nugine deleted the copilot/fix-ci-failure branch February 26, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants