Modified Queue Size Checking and Increased Ethernet Message Size#374
Open
bjackson312006 wants to merge 1 commit intomainfrom
Open
Modified Queue Size Checking and Increased Ethernet Message Size#374bjackson312006 wants to merge 1 commit intomainfrom
bjackson312006 wants to merge 1 commit intomainfrom
Conversation
caiodasilva2005
approved these changes
Mar 6, 2026
Collaborator
Author
|
note: don't merge yet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to this PR in Cerberus-2.0. If we end up changing ThreadX's max queue message size, then we shouldn't manually validate the queue sizes via hardcoded numbers in
queue_create(). We should just let ThreadX return aTX_SIZE_ERRORon its own, which will be propagated to the error checking inqueue_create().Also, increased Ethernet message sizes to 128 bytes, since they're no longer limited by the ThreadX max queue size. I just kind of made this number up. The default payload size is currently set to 1524, but I don't think we should increase the Ethernet message sizes to this unless we really need to, since
tx_queue_receive()seems to always copy over the full message size which would be unnecessary if most of our message are much smaller than that.