Skip to content

cerberus: Fix runtime path look-up#445142

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
RossSmyth:cerberusFix
Oct 14, 2025
Merged

cerberus: Fix runtime path look-up#445142
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
RossSmyth:cerberusFix

Conversation

@RossSmyth
Copy link
Copy Markdown
Contributor

@RossSmyth RossSmyth commented Sep 22, 2025

Things done

Cerberus has passed its integration tests with flying colors. But once out of the build sandbox it stopped running. I have tracked down the issue.

  1. Submitted upstream patch Fix runtime path lookup rems-project/cerberus#980 for finding the correct paths after dune installing
  2. Also patch the source to give a version number that isn't "unknown"
  3. Move codegen binaries to depsBuildBuild
  4. Add parallelization to buildPhase
  5. Build with release profile
  6. install the cerberus runtime library too
  7. Add wrapper that sets the prefix environment variable
  8. Add passthru test to ensure it runs outside the buildsandbox
  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Sep 22, 2025
@Sigmanificient
Copy link
Copy Markdown
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 445142
Commit: 91877b43fe859d481b41543dda45ee157f8359cf (subsequent changes)
Merge: 961e6f1d2fa5c4f4ede1fe1624cc2184fb0935e1

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18251898871


x86_64-linux

✅ 1 package built:
  • cerberus

aarch64-linux

✅ 1 package built:
  • cerberus

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • cerberus

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • cerberus

Comment thread pkgs/by-name/ce/cerberus/package.nix Outdated
@nixpkgs-ci nixpkgs-ci Bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 6, 2025
Comment thread pkgs/by-name/ce/cerberus/package.nix
@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 13, 2025
@SuperSandroBot
Copy link
Copy Markdown

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 445142
Commit: 2b489fb4fbd18a78cca8796a2deadac7463ea709 (subsequent changes)
Merge: 512803857ee73c3bc86a2cc747cc19cda1b6c095

Logs: https://github.com/SuperSandro2000/nixpkgs-review-gha/actions/runs/18480957674


x86_64-linux

✅ 1 package built:
  • cerberus

aarch64-linux

✅ 1 package built:
  • cerberus

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • cerberus

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • cerberus

@SuperSandro2000 SuperSandro2000 added this pull request to the merge queue Oct 14, 2025
Merged via the queue into NixOS:master with commit 4dc008a Oct 14, 2025
28 of 31 checks passed
@RossSmyth RossSmyth deleted the cerberusFix branch October 20, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants