feat: add log level cli option and set reasonable default#731
Open
james-knippes wants to merge 1 commit intomasterfrom
Open
feat: add log level cli option and set reasonable default#731james-knippes wants to merge 1 commit intomasterfrom
james-knippes wants to merge 1 commit intomasterfrom
Conversation
james-knippes
force-pushed
the
feat/dynamic-log-level
branch
from
f7b7344 to
2dcff23
Compare
Member
robin-nitrokey
left a comment
robin-nitrokey
left a comment
There was a problem hiding this comment.
Thanks for the PR! I think we should keep the default log level at least at info. Otherwise the log would be empty by default. Maybe even debug, we’ll have to review where this log level is currently used. Let’s discuss this tomorrow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #728 , as default log level is 'warning' now.