Add support for nistp384 algorithm in PIV#716
Open
n0xena wants to merge 10 commits intoNitrokey:masterfrom
Open
Add support for nistp384 algorithm in PIV#716n0xena wants to merge 10 commits intoNitrokey:masterfrom
n0xena wants to merge 10 commits intoNitrokey:masterfrom
Conversation
failed when copy from local to github web - should have used git push via ssh
Contributor
Author
|
is there a reason why this is held back? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part 2 for #700
again here're some sample data generated on my nk3
signature test over itself - this time with openssl as opensc supports ec-p384
overall this might be refactored later to generalize - but my intent with straight copy'n'paste was to keep simple to read and understand - interweaving the different code paths would just resulted in several if/else inbetween
I also tried to keep the format check happy this time