feat(dkg): implement dkg/disk and dkg/share#285
Open
emlautarom1 wants to merge 43 commits intomainfrom
Open
Conversation
- Add `load_definition`
- Requires `shares`
- Adjust some pending TODOs.
- Fix required file name
- Fix `load_definition_file_does_not_exist` error
- Workaround to be used by dkg
- Impl `From<&Share> for ShareMsg`
- Make everything public - Add docs to all exposed symbols
- We need to create the file first.
Collaborator
We can do it by so |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #252, Closes #257
This PR shows a limitation of the reference implementation module structure:
pluto_cluster::test_clustermodule only for testing purposes.#[cfg(test)]). See: https://users.rust-lang.org/t/unable-to-import-test-module-from-another-crate/127028Until we figure out what is the best approach, the workaround is as follows:
pluto_cluster::test_clusterbehind the test flag.unwraps()).pluto_testutilto avoid pulling test dependencies.With this, the only change to
pluto_cluster's dependencies is swappingrand_coreforrandwhich I believe is quite reasonable.