Set the secure flag on UI cookies when the request is secure#752
Open
buscheri-amazon wants to merge 1 commit intoNetflix:masterfrom
Open
Set the secure flag on UI cookies when the request is secure#752buscheri-amazon wants to merge 1 commit intoNetflix:masterfrom
buscheri-amazon wants to merge 1 commit intoNetflix:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello esteemed hollow maintainers!
Amazon's internal infosec policies dictate that all cookies need to set the secure flag for sites served by
https, and hollow library code was flagged as being in violation of this policy.I've raised this PR to ensure that secure cookies are used when the diff and explorer UIs are served from
httpsendpoints. This should make the hollow web UIs more secure in production environments while still enabling standing up quick localhost instances of the UIs.