Skip to content

Fix bg interaction with interactive renderer#283

Merged
jeffamstutz merged 2 commits intoNVIDIA:next_releasefrom
tarcila:fix-bg-interaction-with-interactive-renderer
Apr 22, 2026
Merged

Fix bg interaction with interactive renderer#283
jeffamstutz merged 2 commits intoNVIDIA:next_releasefrom
tarcila:fix-bg-interaction-with-interactive-renderer

Conversation

@tarcila
Copy link
Copy Markdown
Collaborator

@tarcila tarcila commented Apr 21, 2026

  • Fix background color or image leaking into the lighting computation.
  • Rename tonemap to fireflyFilter. Even if using tonemapper internally, the former name was misleading when considering an actual tonemapping stages as TSD now has.

@tarcila tarcila requested a review from Copilot April 21, 2026 17:14

This comment was marked as outdated.

@tarcila tarcila force-pushed the fix-bg-interaction-with-interactive-renderer branch from 36ee5c9 to 597db32 Compare April 21, 2026 17:29
The parameter controls a reversible firefly-suppression tonemap applied
during sample accumulation, not a user-facing display tonemapping pass.
This was possibly creating confusion with TSD ToneMapPass.
@tarcila tarcila force-pushed the fix-bg-interaction-with-interactive-renderer branch from 597db32 to 469472f Compare April 21, 2026 17:32
@tarcila tarcila requested a review from jeffamstutz April 21, 2026 17:44
@tarcila tarcila force-pushed the fix-bg-interaction-with-interactive-renderer branch from 469472f to b8712ac Compare April 22, 2026 13:02
Copy link
Copy Markdown
Collaborator

@jeffamstutz jeffamstutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jeffamstutz jeffamstutz merged commit 13c9ac2 into NVIDIA:next_release Apr 22, 2026
8 checks passed
@tarcila tarcila deleted the fix-bg-interaction-with-interactive-renderer branch April 22, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants