Skip to content

Refactor IntermediateStep to ATIFConverter#1852

Draft
AnuradhaKaruppiah wants to merge 13 commits intoNVIDIA:release/1.6from
AnuradhaKaruppiah:ak-subagent-traj
Draft

Refactor IntermediateStep to ATIFConverter#1852
AnuradhaKaruppiah wants to merge 13 commits intoNVIDIA:release/1.6from
AnuradhaKaruppiah:ak-subagent-traj

Conversation

@AnuradhaKaruppiah
Copy link
Copy Markdown
Contributor

Description

What changed

  • Reworked packages/nvidia_nat_core/src/nat/utils/atif_converter.py into explicit stages:
    • Pass 1: _pass1_build_execution_structure(...)
      • partitions events into root vs delegated child context
      • builds subagent_ref_by_call_id
    • Pass 2: _pass2_project_context_to_steps(...)
      • projects one context’s events into flat ATIF step rows
  • Renamed/clarified helper responsibilities:
    • _build_flat_observation_rows(...) (explicit flat observation projection)
    • kept projection flat for nested tools; ancestry remains the nesting signal.
  • Kept child trajectories embedded in:
    • trajectory.extra["subagent_trajectories"]
  • Simplified ATIFStreamConverter:
    • now a thin wrapper over the same batch two-pass pipeline
    • buffers IST events, reprojects via IntermediateStepToATIFConverter, returns newly visible steps

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
@AnuradhaKaruppiah AnuradhaKaruppiah self-assigned this Apr 8, 2026
@AnuradhaKaruppiah AnuradhaKaruppiah added improvement Improvement to existing functionality non-breaking Non-breaking change labels Apr 8, 2026
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Apr 8, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 8, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ca336b51-64b5-4d3d-9d44-440096ba5ffb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
…tif.json

Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
@AnuradhaKaruppiah AnuradhaKaruppiah changed the base branch from develop to release/1.6 April 8, 2026 18:21
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement to existing functionality non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant