validate-pr: relax Launchpad bug link check to existence only#399
Open
nirmoy wants to merge 1 commit intoNVIDIA:github-actionsfrom
Open
validate-pr: relax Launchpad bug link check to existence only#399nirmoy wants to merge 1 commit intoNVIDIA:github-actionsfrom
nirmoy wants to merge 1 commit intoNVIDIA:github-actionsfrom
Conversation
Drop the requirement that the Launchpad URL appear at the start of a line prefixed with 'BugLink:' or 'LP:'. The check now only ensures a https://bugs.launchpad.net/... URL exists somewhere in the PR body. This avoids false negatives when authors paste the link in prose or without a strict prefix, while still ensuring every PR targeting a tracked branch references a Launchpad bug. Signed-off-by: Nirmoy Das <nirmoyd@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BugLink:orLP:.https://bugs.launchpad.net/...URL exists somewhere in the PR body.