if a rule application is found, do not increase the deletion index#133
Merged
georghinkel merged 1 commit intomainfrom Mar 11, 2026
Merged
if a rule application is found, do not increase the deletion index#133georghinkel merged 1 commit intomainfrom
georghinkel merged 1 commit intomainfrom
Conversation
⚡ Risk Assessment —
|
| Files | Summary |
|---|---|
Core Bug Fix in List Migration LogicAnyText/AnyText.Core/ChangeTracker.cs |
Fixes deletion index to use 'index' instead of 'index + indexOffset' when rule applications are found, and adds handling for index==0 with prior edits to properly remove obsoleted entries |
Test and ChangelogAnyText/Tests/AnyText.Tests/Diffs/DiffParserTests.csAnyText/AnyText.history |
Adds new test file for DiffParser and records the bug fix in the changelog |
Sequence Diagram
sequenceDiagram\n participant Old as Old List\n participant Calc as CalculateListMigrations\n participant Fix as Index Calculation\n participant Result as Migration Entries\n Old->>Calc: Process rule applications\n Calc->>Fix: Calculate deletion index\n Fix-->>Calc: Use 'index' not 'index+indexOffset'\n Calc->>Result: Add Remove entries with correct index\n Note over Calc,Fix: Bug fix: was causing wrong entries to be removed
Dig Deeper With Commands
/review <file-path> <function-optional>/chat <file-path> "<question>"/roast <file-path>
Runs only when explicitly triggered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by MergeMonkey