Allow user to override tile level calculation#1566
Open
xawill wants to merge 1 commit intoNASA-AMMOS:masterfrom
Open
Allow user to override tile level calculation#1566xawill wants to merge 1 commit intoNASA-AMMOS:masterfrom
xawill wants to merge 1 commit intoNASA-AMMOS:masterfrom
Conversation
Contributor
Author
|
Thinking about it a bit more, there might be an issue with returning false from Anyway it looks like a bit hacky to be able to return null from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following discussion in #1278.
In this proposal,
calculateLevelcan now returnnull. This user-override indicates that the current tile has no content and should not be rendered. Let me know what you think about it. An alternative would be to supportminLevelandmaxLevelonTiledImageOverlay. In that case, we might want to clamplevelbetweenminLevelandmaxLevelincalculateLevel, even though after testing it I noticed that the rest of the codebase is already clampingleveleverywhere I checked.