Skip to content

add cmd args for sekotalk v2.7#952

Merged
helloyongyang merged 1 commit intomainfrom
dev/format
Mar 18, 2026
Merged

add cmd args for sekotalk v2.7#952
helloyongyang merged 1 commit intomainfrom
dev/format

Conversation

@wangshankun
Copy link
Collaborator

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the rs2v_infer.py script by externalizing the infer_steps and video_duration parameters into command-line arguments. This change provides greater flexibility for users to customize video generation settings without modifying the source code directly, improving the adaptability of the SekoTalk v2.7 application. The associated example scripts have been updated to demonstrate the usage of these new configurable options.

Highlights

  • Command-line Arguments: Introduced new command-line arguments --infer_steps and --video_duration to the rs2v_infer.py script, allowing dynamic configuration of these parameters.
  • Configuration Update: Removed hardcoded infer_steps and video_duration values from the init_input_info_from_args function call, now relying on the newly added command-line arguments.
  • Script Examples: Updated example shell scripts (run_rs2v.sh and run_rs2v_multi_person.sh) to utilize the new --infer_steps and --video_duration command-line arguments.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request refactors the rs2v_infer.py script to accept infer_steps and video_duration as command-line arguments instead of hardcoding them within the init_input_info_from_args function call. This change introduces new ArgumentParser arguments for these parameters with default values. Corresponding shell scripts, run_rs2v.sh and run_rs2v_multi_person.sh, are updated to pass specific infer_steps and video_duration values via these new command-line options.

@helloyongyang helloyongyang merged commit 2cc1c00 into main Mar 18, 2026
2 checks passed
@helloyongyang helloyongyang deleted the dev/format branch March 18, 2026 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants