[7.0] Add a more helpful error message when validator init fails#111
Open
PaintNinja wants to merge 1 commit intoMinecraftForge:masterfrom
Open
[7.0] Add a more helpful error message when validator init fails#111PaintNinja wants to merge 1 commit intoMinecraftForge:masterfrom
PaintNinja wants to merge 1 commit intoMinecraftForge:masterfrom
Conversation
Member
|
Instead of throwing an error, would it be better to allow the annotation processor to be applied (since we do it by default in the mdk) and just disable itself if it detects this case? |
Contributor
Author
|
Possibly, but you'd still be paying the overhead of the compiler setting up the AP environment and sending each source file to it. The MDK is unaffected by this issue as far as I'm aware, as Forge transitively includes EventBus and there's no module-info in the MDK. To trigger the issue, you need to run the AP on a project that is missing EventBus or where the project being validated has an explicit module but missing requires statement. |
Member
|
Fair enough. Haven't looked into this part of the compiler so not sure how much of a cost it is vs having no APs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #109. Thanks to @basdxz for finding the root cause of the issue.