MDEV-38033: JSON_SCHEMA_VALID returns wrong result for array of objects#4755
Merged
grooverdan merged 1 commit intoMariaDB:12.3from Mar 9, 2026
Merged
MDEV-38033: JSON_SCHEMA_VALID returns wrong result for array of objects#4755grooverdan merged 1 commit intoMariaDB:12.3from
grooverdan merged 1 commit intoMariaDB:12.3from
Conversation
Fix a bug in Json_schema_items::validate where it was missing a json_skip_level() call. Without this skip, the validator would incorrectly recurse into non-scalar array elements (like objects) and try to validate their internal keys/values against the array's item schema.
Author
|
@grooverdan This is the same PR as #4727 (The old branch name contained 12.1, so I wanted it to change to 12.3). |
gkodinov
added
the
External Contribution
gkodinov
approved these changes
Mar 9, 2026
Member
gkodinov
left a comment
gkodinov
left a comment
There was a problem hiding this comment.
This is restoring the preliminary review state for the other PR.
Please work with Rucha on the final review.
Member
Yep, unfortunate you can't rename the branch name of a PR. I've started to not include version in branches, but overall it doesn't matter too much if its misnamed, the branch its on soon gets forgotten after its merged :-) |
Member
|
Thanks for the fix @abhishek593! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug in Json_schema_items::validate where it was missing a json_skip_level() call. Without this skip, the validator would incorrectly recurse into non-scalar array elements (like objects) and try to validate their internal keys/values against the array's item schema.