Open
Conversation
…ore trying to read BPB. This is particulary important during a re-mount of a previously mounted storage device. BUT: do not try to seek in an debug_assert!() - otherwise this important side effect will not happen in a release build.
hsteinhaus
force-pushed
the
remount-fixes
branch
2 times, most recently
from
cbbfcd9 to
24c9e0b
Compare
Owner
|
Why not just seek back to zero before passing the storage back into the new filesystem? |
Author
|
Counter question: should the outcome of an attempt to mount an fs really depend on the state of the underlying block device? I personally would find this behaviour at least surprising. |
Owner
|
Fair enough, in which case remove the debug assert, I don't think it does anything anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the use case of unmounting a file system after use and re-mounting it immediately again from the same storage device.