Return an error when encountering corrupted lfn entry#32
Return an error when encountering corrupted lfn entry#32aurelj wants to merge 2 commits intoMabezDev:masterfrom
Conversation
MabezDev
left a comment
There was a problem hiding this comment.
Hmm, I'm not so sure about this change.
CorruptedFileSystem should only be returned when something critical to the operation of the FS has gone wrong, either the boot sector is corrupted or fsinfo is. Imo corruption of a single file or in this case file name entry is not a reason to return this error.
Do defmt logs really matter that much? IIRC I think there is a way to disable defmt logs for a certain crate module: https://defmt.ferrous-systems.com/filtering.html.
|
Indeed, I agree But filtering defmt logs sounds a bit hacky and adds the risk of missing some other unrelated and important messages.
|
e26a702 to
636de0f
Compare
Without this, on a corrupted fs, I get hundreds of "corrupted lfn entry!" messages printed thru defmt for a single read_dir_entry() call.