Skip to content

Fix grounding line mask definition when creating landice meshes#935

Merged
matthewhoffman merged 2 commits intoMPAS-Dev:mainfrom
trhille:fix_grounding_line_mask
Apr 3, 2026
Merged

Fix grounding line mask definition when creating landice meshes#935
matthewhoffman merged 2 commits intoMPAS-Dev:mainfrom
trhille:fix_grounding_line_mask

Conversation

@trhille
Copy link
Copy Markdown
Collaborator

@trhille trhille commented Feb 26, 2026

This merge fixes grounding line mask definition, which previously marked the entire ocean as the grounding line used for setting cell widths. It also saves maps of the margin and grounding-line masks, which will be helpful for debugging purposes when new maps are added or mask definitions are changed.

Checklist

  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

@trhille
Copy link
Copy Markdown
Collaborator Author

trhille commented Feb 26, 2026

Testing

I tested this on the Greenland mesh with 4–40km resolution. Using thee previous definition of the grounding-line mask, we get a mask that is really a union of open ocean and floating ice masks:
Screenshot 2026-02-26 at 11 37 28 AM
Using this update, we get:
Screenshot 2026-02-26 at 12 22 50 PM

These maps are now saved as pngs in the mesh_gen case directory.

Note that this doesn't make much practical difference for the Greenland mesh, since we take the minimum of the distances to the grounding line and ice margin. The cell area using the previous grounding line mask is shown on the left (nCells = 29953), with the changes in this merge shown on the right (nCells = 29748 ):

image

@matthewhoffman
Copy link
Copy Markdown
Member

@trhille , the maps look great and I like that you are now saving them out. I am happy to approve & merge once we're happy with that question about the logic for the masks.

trhille added 2 commits March 18, 2026 11:13
Fix grounding line mask definition, which previously marked the entire
ocean as the grounding line used for setting cell widths.
Simplify logic for creating margin and grounding-line masks for
landice mesh creation.
@trhille trhille force-pushed the fix_grounding_line_mask branch from d04d7ff to dc22f87 Compare March 18, 2026 19:06
@matthewhoffman matthewhoffman self-assigned this Apr 3, 2026
@matthewhoffman matthewhoffman merged commit 0e2066c into MPAS-Dev:main Apr 3, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants