Skip to content

Fix non-editable install#1140

Merged
xylar merged 2 commits intoMPAS-Dev:developfrom
xylar:fix-non-editable-install
Mar 30, 2026
Merged

Fix non-editable install#1140
xylar merged 2 commits intoMPAS-Dev:developfrom
xylar:fix-non-editable-install

Conversation

@xylar
Copy link
Copy Markdown
Collaborator

@xylar xylar commented Mar 30, 2026

Checklist

  • Testing comment in the PR documents testing used to verify the changes

@xylar xylar requested a review from vanroekel March 30, 2026 16:43
@xylar xylar self-assigned this Mar 30, 2026
@xylar xylar added the bug label Mar 30, 2026
@xylar
Copy link
Copy Markdown
Collaborator Author

xylar commented Mar 30, 2026

Testing

I ran:

$ pixi shell
$ pip install .
$ mpas_anlysis -h

and it worked as expected.

However, I haven't been able to reproduce the original problem:

ac.vanroekel@chrlogin2:/lcrc/group/e3sm/ac.vanroekel/add-regional-mht$ mpas_analysis -h Traceback (most recent call last): File "/lcrc/group/e3sm/ac.vanroekel/add-regional-mht/.pixi/envs/default/bin/mpas_analysis", line 10, in <module> sys.exit(main()) ~~~~^^ File "/lcrc/group/e3sm/ac.vanroekel/add-regional-mht/mpas_analysis/__main__.py", line 999, in main mpas_analysis_dir = get_editable_install_dir('mpas_analysis') File "/lcrc/group/e3sm/ac.vanroekel/add-regional-mht/mpas_analysis/__main__.py", line 946, in get_editable_install_dir contents = json.loads(direct_url) File "/lcrc/group/e3sm/ac.vanroekel/add-regional-mht/.pixi/envs/default/lib/python3.14/json/__init__.py", line 345, in loads raise TypeError(f'the JSON object must be str, bytes or bytearray, ' f'not {s.__class__.__name__}') TypeError: the JSON object must be str, bytes or bytearray, not NoneType

So I'm not 100% sure of the fix yet.

@vanroekel
Copy link
Copy Markdown
Collaborator

@xylar I just tested MPAS-Analysis/develop on pm-cpu and saw no errors, I tried fresh on chrysalis and see the error. Did you test on chrysalis? If so, I wonder if I have something in my bashrc causing issues.

@xylar
Copy link
Copy Markdown
Collaborator Author

xylar commented Mar 30, 2026

Yes, I was working on Chrysalis for all my testing today and never saw the error. Do you see the error even with this branch on Chrysalis?

@vanroekel
Copy link
Copy Markdown
Collaborator

Sorry, that was just with develop. I'll test the branch now.

Copy link
Copy Markdown
Collaborator

@vanroekel vanroekel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't understand the different behavior for my testing (and across chrysalis to perlmutter). But, this fixes the issue I observe on chrysalis. Thanks @xylar

@xylar
Copy link
Copy Markdown
Collaborator Author

xylar commented Mar 30, 2026

Glad to hear it, @vanroekel!

@xylar xylar merged commit 0eb9ef4 into MPAS-Dev:develop Mar 30, 2026
10 checks passed
@xylar xylar deleted the fix-non-editable-install branch March 30, 2026 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants