Updates and fixes before release#958
Merged
VincentVanlaer merged 27 commits intor25.12.1_colors_updatedfrom Apr 11, 2026
Merged
Updates and fixes before release#958VincentVanlaer merged 27 commits intor25.12.1_colors_updatedfrom
VincentVanlaer merged 27 commits intor25.12.1_colors_updatedfrom
Conversation
nialljmiller
approved these changes
Apr 8, 2026
Member
Author
|
For the record: This pr addresses #939, and I will probably close the other PR since it will be cherry picked later along with the changes in this branch |
Debraheem
requested review from
VincentVanlaer,
matteocantiello,
mjoyceGR and
rhdtownsend
Debraheem
added
release-blocker
Member
Author
|
I believe this is the item list in order for the release:
From there Vincent and I will handle the release. |
Member
|
I have fixed the conflicts locally, is there anything else that needs to be added to this branch or are we good? |
Member
Author
|
I think it's fine, but we might want to cherry pick the timestep fix carl raised. Then it just needs testing, and it's ready. |
VincentVanlaer
force-pushed
the
updates_and_fixes_before_release
branch
from
8c9b97f to
f415d1d
Compare
Updated comments for clarity on stellar atmosphere model path and requirements.
Removed older SDK version from the build matrix.
Tests Vega magnitudes (Kurucz2003, Johnson) and sampled SED flux values for three stellar parameter sets (solar, hot MS, cool giant) against a reference test_output generated from a known-good state of the code.
…on mac and linux here. I can only test by github actions here.
…on mac and linux here. I can only test by github actions here.
Added references for Castelli & Kurucz 2003 and SVO model in the colors.defaults file.
Added details about colors data and alpha-element enhancement in the README.
…elog entries and known bugs
VincentVanlaer
force-pushed
the
updates_and_fixes_before_release
branch
from
f415d1d to
6d793a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr stacks the last changes from Eb and Niall into one pr to merge into r25.12.1_colors_updated.