update stella_extras to work with new colors module#926
Merged
VincentVanlaer merged 2 commits intor25.12.1_colors_updatedfrom Apr 11, 2026
Merged
Conversation
Member
|
I think this call would also need to be replaced by the new interfaces , or the current stubs would need to be implemented. I am not familiar enough with the color system to know which option would be best/workable. |
nialljmiller
force-pushed
the
features/nialljmiller/customcolors_stellaupdate
branch
from
428c9fb to
f157358
Compare
Collaborator
Author
|
I believe this is now addressed. I have tested it and it compiles with the new colors code. |
VincentVanlaer
force-pushed
the
features/nialljmiller/customcolors_stellaupdate
branch
from
2aa843f to
2a440a3
Compare
VincentVanlaer
requested review from
Debraheem,
fxt44,
mjoyceGR,
orlox,
rhdtownsend and
rsmolec
as code owners
VincentVanlaer
deleted the
features/nialljmiller/customcolors_stellaupdate
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to
stella/res/stella_extras.f90to make it compatible with the new colors module