Check if players have cells when compiling the leaderboard #52#53
Open
bradennss wants to merge 4 commits intoLuka967:masterfrom
bradennss:master
Open
Check if players have cells when compiling the leaderboard #52#53bradennss wants to merge 4 commits intoLuka967:masterfrom bradennss:master
bradennss wants to merge 4 commits intoLuka967:masterfrom
bradennss:master
Conversation
|
I tried this pullrequest + cWS, when trying to join gives me error
|
Author
|
@freaky767 Just remove that line, it's not needed. |
|
using pull request; works! |
Rivet-archived
approved these changes
Jun 6, 2021
| }, | ||
| "dependencies": { | ||
| "uws": "10.148.1" | ||
| "@clusterws/cws": "^0.16.0" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
State is inconsistent, either
scoreisn’t being updated before the leaderboard is compiled, or it’s not reactive at all toownedCells. Spoke with Luka directly when I encountered this a few months ago, it’s likely a timing bug.