Skip to content

Exclude invalid selectors #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LinqLover wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Exclude invalid selectors #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/Autocompletion.package/ECSymbols.class/class/contains.caseSensitive.exclude.do..st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
as yet unclassified
accessing
contains: aString caseSensitive: aBoolean exclude: aCollection do: aBlock

| separators |
Expand All @@ -7,5 +7,6 @@ contains: aString caseSensitive: aBoolean exclude: aCollection do: aBlock
separators := CharacterSet separators.
Symbol allSymbolTablesDo: [:each |
((each indexOfAnyOf: separators startingAt: 1) = 0 and: [(aCollection includes: each) not]
and: [each includesSubstring: aString caseSensitive: aBoolean])
and: [(each includesSubstring: aString caseSensitive: aBoolean)
and: [self isValidSelector: each]])
ifTrue: [aBlock value: each]].
6 changes: 6 additions & 0 deletions packages/Autocompletion.package/ECSymbols.class/class/isValidSelector..st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
testing
isValidSelector: aSymbol

"ct: ~24% faster than uncached (58ms vs 75ms for Symbol allSymbols)"
^ (SymbolValidities ifNil: [SymbolValidities := WeakIdentityKeyDictionary new])
at: aSymbol ifAbsentPut: [aSymbol isMessageSelector]
3 changes: 2 additions & 1 deletion packages/Autocompletion.package/ECSymbols.class/methodProperties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"class" : {
"contains:caseSensitive:do:" : "LM 3/20/2019 15:22",
"contains:caseSensitive:exclude:do:" : "LM 3/20/2019 15:22" },
"contains:caseSensitive:exclude:do:" : "ct 12/21/2023 21:00",
"isValidSelector:" : "ct 12/21/2023 21:05" },
"instance" : {
} }
2 changes: 1 addition & 1 deletion packages/Autocompletion.package/ECSymbols.class/properties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"classinstvars" : [
],
"classvars" : [
],
"SymbolValidities" ],
"commentStamp" : "",
"instvars" : [
],
Expand Down