Skip to content

[PLT-0] Fix flaky test_request_labeling_service_moe_project#2049

Merged
mrobers1982 merged 1 commit intodevelopfrom
pnoirel/PLT-0-fix-deadlock-in-model-eval-fixture
Mar 18, 2026
Merged

[PLT-0] Fix flaky test_request_labeling_service_moe_project#2049
mrobers1982 merged 1 commit intodevelopfrom
pnoirel/PLT-0-fix-deadlock-in-model-eval-fixture

Conversation

@lb-pno
Copy link
Contributor

@lb-pno lb-pno commented Mar 9, 2026

Description

Remove unused live_chat_evaluation_project dependency from live_chat_evaluation_project_with_batch fixture and add retry logic for transient ER_LOCK_DEADLOCK errors. The redundant dependency triggered an extra create_model_evaluation_project call that increased deadlock probability.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

Note

Low Risk
Test-only fixture changes add retry/backoff around project creation, which could slightly increase test runtime but doesn’t affect production code paths.

Overview
Reduces flakiness in test_request_labeling_service_moe_project setup by removing the unused live_chat_evaluation_project dependency from live_chat_evaluation_project_with_batch, avoiding an extra create_model_evaluation_project call.

Adds a small retry-with-sleep loop around client.create_model_evaluation_project to handle transient ER_LOCK_DEADLOCK errors when tests run in parallel.

Written by Cursor Bugbot for commit 3ab3633. This will update automatically on new commits. Configure here.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants