[PLT-0] Fix flaky test_request_labeling_service_moe_project#2049
Merged
mrobers1982 merged 1 commit intodevelopfrom Mar 18, 2026
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove unused live_chat_evaluation_project dependency from
live_chat_evaluation_project_with_batchfixture and add retry logic for transient ER_LOCK_DEADLOCK errors. The redundant dependency triggered an extracreate_model_evaluation_projectcall that increased deadlock probability.Fixes # (issue)
Type of change
Please delete options that are not relevant.
All Submissions
New Feature Submissions
Changes to Core Features
Note
Low Risk
Test-only fixture changes add retry/backoff around project creation, which could slightly increase test runtime but doesn’t affect production code paths.
Overview
Reduces flakiness in
test_request_labeling_service_moe_projectsetup by removing the unusedlive_chat_evaluation_projectdependency fromlive_chat_evaluation_project_with_batch, avoiding an extracreate_model_evaluation_projectcall.Adds a small retry-with-sleep loop around
client.create_model_evaluation_projectto handle transientER_LOCK_DEADLOCKerrors when tests run in parallel.Written by Cursor Bugbot for commit 3ab3633. This will update automatically on new commits. Configure here.