Skip to content

Impersonating Troubleshooters can now impersonate users and groups#7465

Draft
labkey-adam wants to merge 4 commits intodevelopfrom
fb_impersonation
Draft

Impersonating Troubleshooters can now impersonate users and groups#7465
labkey-adam wants to merge 4 commits intodevelopfrom
fb_impersonation

Conversation

@labkey-adam
Copy link
Contributor

@labkey-adam labkey-adam commented Mar 2, 2026

Rationale

https://github.com/LabKey/internal-issues/issues/837

Changes

  • The only functional change to note is that Impersonating Troubleshooters can impersonate users and groups in the root. If they happen to have read permissions in a project or folder, they can impersonate users, groups, and roles there as well.
  • Internally, I've reworked impersonation permissions checking to eliminate duplicate checks. A new ImpersonatePermission class is now used instead of AdminPermission as the primary check. Action-level and manager permission checking has been removed; all permission checking is performed by a single method in each impersonation context for simplicity and consistency.

@labkey-adam labkey-adam marked this pull request as draft March 2, 2026 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant