Rename tables and columns with names that are too long for PostgreSQL#7458
Open
labkey-adam wants to merge 7 commits intodevelopfrom
Open
Rename tables and columns with names that are too long for PostgreSQL#7458labkey-adam wants to merge 7 commits intodevelopfrom
labkey-adam wants to merge 7 commits intodevelopfrom
Conversation
labkey-adam
requested review from
labkey-jeckels,
labkey-klum,
labkey-martyp and
labkey-matthewb
labkey-jeckels
approved these changes
Mar 2, 2026
experiment/src/org/labkey/experiment/DataClassMigrationSchemaHandler.java
Outdated
Show resolved
Hide resolved
| LOG.info(" Table \"{}\" renamed to \"{}\" ({} bytes)", oldName, newName, newName.getBytes(StandardCharsets.UTF_8).length); | ||
| }); | ||
|
|
||
| List<String> badTableNames = new TableSelector(tinfoDomainDescriptor, new CsvSet("StorageTableName"), filter, null) |
Contributor
There was a problem hiding this comment.
This seems odd. If it's needed, would it be better to capture them in the forEach? I don't think we're getting value out of setting it in the DB and then querying the DB for them.
Contributor
Author
There was a problem hiding this comment.
I added it to verify that the renaming steps worked as expected. There are a lot of moving parts... especially with the multi-step column-renaming process. The table-renaming steps used to be more complex; I simplified them, but it seemed reasonable to leave the check in.
experiment/src/org/labkey/experiment/ExperimentUpgradeCode.java
Outdated
Show resolved
Hide resolved
experiment/src/org/labkey/experiment/ExperimentUpgradeCode.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Microsoft SQL Server allows table and column names that are longer than what PostgreSQL allows (128 characters vs. 63 UTF-8 bytes). Long names on SQL Server can foul up the SQL Server to PostgreSQL migration process. We address this by renaming all existing SQL Server long table/column names and updating SQL Server to produce PostgreSQL-compatible names going forward.
https://github.com/LabKey/internal-issues/issues/869