Skip to content

Allow Symfony 8#254

Merged
Kreyu merged 3 commits intoKreyu:mainfrom
daFish:build/symfony-8
Apr 12, 2026
Merged

Allow Symfony 8#254
Kreyu merged 3 commits intoKreyu:mainfrom
daFish:build/symfony-8

Conversation

@daFish
Copy link
Copy Markdown
Contributor

@daFish daFish commented Mar 6, 2026

This change allows the installation with Symfony 8. It also installs symfony/var-exporter to be compatible with Doctrine ORM 3.0.

@daFish daFish force-pushed the build/symfony-8 branch from 179f3ad to 1f3c20c Compare March 6, 2026 12:49
@barbieswimcrew
Copy link
Copy Markdown

really looking forward to this <3

@mwansinck
Copy link
Copy Markdown
Contributor

mwansinck commented Mar 20, 2026

@daFish I tried to use your fork and found some issues;

------ ------------------------------------------------------------------------------------------------------------------- 
  Line   src/DataCollector/DataTableDataCollector.php                                                                       
 ------ ------------------------------------------------------------------------------------------------------------------- 
  43     Call to an undefined static method Symfony\Bundle\FrameworkBundle\DataCollector\AbstractDataCollector::__sleep().  
 ------ ------------------------------------------------------------------------------------------------------------------- 

https://github.com/symfony/symfony/blob/8.0/UPGRADE-8.0.md#httpkernel

 ------ ------------------------------------------------------------------------------ 
  Line   src/Request/HttpFoundationRequestHandler.php                                  
 ------ ------------------------------------------------------------------------------ 
  51     Call to an undefined method Symfony\Component\HttpFoundation\Request::get().  
  108    Call to an undefined method Symfony\Component\HttpFoundation\Request::get().  
  125    Call to an undefined method Symfony\Component\HttpFoundation\Request::get().  
 ------ ------------------------------------------------------------------------------ 

https://github.com/symfony/symfony/blob/8.0/UPGRADE-8.0.md#httpfoundation

@daFish
Copy link
Copy Markdown
Contributor Author

daFish commented Mar 23, 2026

@mwansinck Will check it.

@davidnectarestudio
Copy link
Copy Markdown
Contributor

thanks @daFish

@daFish
Copy link
Copy Markdown
Contributor Author

daFish commented Mar 24, 2026

Ok, the support for Symfony 7 & 8 is now handled.

@mwansinck
Copy link
Copy Markdown
Contributor

mwansinck commented Mar 24, 2026

Ok, the support for Symfony 7 & 8 is now handled.

Great work!

@Kreyu Could you review the PR from @daFish ?
You also mentioned you don't have the time to invest on this project anymore. We think this bundle is however very useful (and maybe the only good Datatable implementation in Symfony at all). Are you open for other maintainers on this project?

@Kreyu
Copy link
Copy Markdown
Owner

Kreyu commented Apr 12, 2026

Thank you for the contribution and sorry for the delay.

@mwansinck probably yes, I'm still thinking on how to handle this properly

@Kreyu Kreyu merged commit 106cc3d into Kreyu:main Apr 12, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants