Handle malformed RFC 2231 continuations in parse_options_header#270
Open
manunio wants to merge 4 commits intoKludex:mainfrom
Open
Handle malformed RFC 2231 continuations in parse_options_header#270manunio wants to merge 4 commits intoKludex:mainfrom
parse_options_header#270manunio wants to merge 4 commits intoKludex:mainfrom
Conversation
…zed RFC 2231 index
…FC 2231 continuations
parse_options_header
Owner
|
Thanks @manunio 🙏 |
Kludex
approved these changes
Apr 25, 2026
Contributor
Author
|
I’m returning the header as is to avoid regex magic for parser differences between python versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ValueError(oversized RFC 2231 index) andTypeError(mixed continuation forms) fromMessage.get_params()Why
parse_options_headerrelied on stdlib email parsing that can raise different exception types for malformed parameter continuations. These changes keep existing behavior while making parser failure handling robust and preventing constant fuzzer crashes(improves its performance)Validation
uv run pytest -quv run ruff check python_multipart/exceptions.py python_multipart/multipart.py tests/test_multipart.py