This repository was archived by the owner on Jan 6, 2022. It is now read-only.
Improved log output for mod loading#527
Open
Dunkhan wants to merge 1 commit intoKeenSoftwareHouse:masterfrom
Open
Improved log output for mod loading#527Dunkhan wants to merge 1 commit intoKeenSoftwareHouse:masterfrom
Dunkhan wants to merge 1 commit intoKeenSoftwareHouse:masterfrom
Conversation
…rials in mods Supressed 'None extensions' logging when emtpy extensions array was passed on purpose Added prefab path to prefab logging Fixed issue where contentFile was set to null before being logged in 'Resource not found' log message
|
If only all PRs were as clear as this. Nice work! |
Author
|
I checked the conflict and it is nothing. Basically an output string has slightly different text in my branch. When merging you can take either version it should not make a difference. Let me know if you want me to resolve this myself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit message:
Added logging for loading of all components, cubeblocks an voxel materials in mods
Supressed 'None extensions' logging when empty extensions array was passed on purpose
Added prefab path to prefab logging
Fixed issue where contentFile was set to null before being logged in 'Resource not found' log message
Explanation:
Troubleshooting XML mods is very difficult, usually the current version just says which file failed, and in some mods where files can reach thousands of lines with just a handful of added blocks, this can result in a lot of trial and error before finding the errors in the xml. This changeset logs the name of each component, voxel material and cubeblock as it is loaded so that it can be seen which one has failed.
The changes also include a cleanup of the existing debug output including the spam of 'Loading prefab' messages and the 'None file extensions' spam which should be familiar to most modders.