Conversation
added 13 commits
April 27, 2026 11:33
extra allowance for the locally cached timestamp being None.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initial implementation of the Payload class was more like the Message class, with defined standard attributes that were always present. Once the Payload class was expanded to handle arbitrary keyword arguments it wasn't clear why the canonical attributes were necessary in all cases; in some situations they were an active detriment, and resulted in extra JSON serialization where the extra fields had no meaning-- like an empty 'value' assignment.
This pull request eliminates the standard attributes from the Payload, instead only using arbitrary keyword arguments. The absence of the canonical attributes means that several "is None" checks had to be converted to try/except blocks, but otherwise the flow is the same.