Skip to content

Sparse payload#37

Draft
klanclos wants to merge 13 commits intomainfrom
sparse_payload
Draft

Sparse payload#37
klanclos wants to merge 13 commits intomainfrom
sparse_payload

Conversation

@klanclos
Copy link
Copy Markdown
Contributor

The initial implementation of the Payload class was more like the Message class, with defined standard attributes that were always present. Once the Payload class was expanded to handle arbitrary keyword arguments it wasn't clear why the canonical attributes were necessary in all cases; in some situations they were an active detriment, and resulted in extra JSON serialization where the extra fields had no meaning-- like an empty 'value' assignment.

This pull request eliminates the standard attributes from the Payload, instead only using arbitrary keyword arguments. The absence of the canonical attributes means that several "is None" checks had to be converted to try/except blocks, but otherwise the flow is the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant