Skip to content

Fixes job spawner for legacy npc #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zeng-github01 wants to merge 4 commits into
base: dev
Choose a base branch
from
+8 −0
Open

Fixes job spawner for legacy npc #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b578d53
Fixes Spawner for legacy
zeng-github01 Apr 5, 2026
6bdf77a
Fixes Spawner for legacy
zeng-github01 Apr 5, 2026
2c2fd84
Merge remote-tracking branch 'origin/Fixes-JobSpawner' into Fixes-Job…
zeng-github01 Apr 5, 2026
1c20abe
Fix NBT for legacy npc
zeng-github01 Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/main/java/noppes/npcs/VersionCompatibility.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,10 @@ public static void CheckNpcCompatibility(EntityNPCInterface npc, NBTTagCompound

compound.setIntArray("StartPosNew", new int[]{x, y, z});
}

if (compound.hasKey("SpawnerDoesntDie") && !compound.hasKey("DespawnOnTargetLost")) {
compound.setBoolean("DespawnOnTargetLost", true);
}
}
if (npc.npcVersion == 13) {
boolean bo = compound.getBoolean("HealthRegen");
Expand Down
4 changes: 4 additions & 0 deletions src/main/java/noppes/npcs/roles/JobSpawner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,10 @@ public void setJobCompound(int i, NBTTagCompound compound) {

@Override
public void aiUpdateTask() {
if (spawned.isEmpty()) {
spawned = getNearbySpawned();
}

if (spawned.isEmpty()) {
if (spawnType == 0) {
if (spawnEntity(number + 1) == null && !doesntDie)
Expand Down
Loading